-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Default api to new free plan #1118
Conversation
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
- Coverage 96.06% 95.71% -0.35%
==========================================
Files 837 750 -87
Lines 19756 14572 -5184
==========================================
- Hits 18979 13948 -5031
+ Misses 777 624 -153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| free_plan = Plan.objects.select_related("tier").get( | ||
| name=PlanName.BASIC_PLAN_NAME.value | ||
| ) | ||
| free_plan = Plan.objects.select_related("tier").get(name=DEFAULT_FREE_PLAN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: rename this to default_plan = ...
|
This PR includes changes to |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Purpose/Motivation
What is the feature? Why is this being done?
We are replacing occurrences of the basic free plan with the new users-developer plan. As part of this change, we are defaulting users to the new plan if the basic plan is sent. This ensures the change takes effect immediately on Gazebo's side and will be removed once Gazebo is updated to use the new plan.
Additionally, I’ve included tests and removed the basic plan from mocks.
Links to relevant tickets
Closes Update Plan Service Logic to use new Free Plan in API
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.